Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Unreal Crash Reporter event level #1677

Merged
merged 11 commits into from
Dec 12, 2022
Merged

feat: Unreal Crash Reporter event level #1677

merged 11 commits into from
Dec 12, 2022

Conversation

bitsandfoxes
Copy link
Contributor

The Unreal Crash Reporter allows for sending events triggered not only through crashes but asserts
and ensures as well. Right now, everything reported through the Unreal Crash Reporter ends up with the event level fatal.

Proposal:

  • Asserts (Check): Halt the execution and will be reported as Error
  • Ensure: Do not halt execution and will be reported as Warning

@bitsandfoxes bitsandfoxes requested a review from a team December 6, 2022 14:47
@bitsandfoxes bitsandfoxes changed the title fix: Unreal event level fix: Unreal Crash Reporter event level Dec 6, 2022
@bitsandfoxes bitsandfoxes marked this pull request as draft December 6, 2022 14:56
@bitsandfoxes bitsandfoxes changed the title fix: Unreal Crash Reporter event level feat: Unreal Crash Reporter event level Dec 7, 2022
@bitsandfoxes bitsandfoxes marked this pull request as ready for review December 7, 2022 13:08
@bitsandfoxes bitsandfoxes requested a review from jan-auer December 7, 2022 13:08
jjbayer
jjbayer reviewed Dec 9, 2022
View reviewed changes
Copy link
Member

@jjbayer jjbayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, would be nice to add some test coverage though.

jjbayer
jjbayer approved these changes Dec 12, 2022
View reviewed changes
Copy link
Member

@jjbayer jjbayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding tests!

@bitsandfoxes bitsandfoxes merged commit f884122 into master Dec 12, 2022
@bitsandfoxes bitsandfoxes deleted the fix/unreal-event-level branch December 12, 2022 17:57
@bitsandfoxes bitsandfoxes mentioned this pull request Jan 11, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jjbayer jjbayer jjbayer approved these changes

@jan-auer jan-auer Awaiting requested review from jan-auer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bitsandfoxes @jjbayer